#linuxcnc-devel | Logs for 2018-10-15
Back
[01:14:12] -!- c-log has quit [Ping timeout: 252 seconds]
[01:15:44] -!- c-log has joined #linuxcnc-devel
[01:22:51] -!- W1N9Zr0 has quit [Ping timeout: 246 seconds]
[01:23:51] -!- W1N9Zr0 has joined #linuxcnc-devel
[03:01:46] -!- Robh__ has joined #linuxcnc-devel
[03:06:02] -!- ve7it has quit [Remote host closed the connection]
[03:08:24] -!- KGB-wlo has quit [Ping timeout: 252 seconds]
[03:09:36] -!- KGB-wlo has joined #linuxcnc-devel
[03:14:55] -!- rob_h has joined #linuxcnc-devel
[03:18:22] -!- Robh__ has quit [Ping timeout: 272 seconds]
[03:35:25] -!- rmu has joined #linuxcnc-devel
[06:02:17] -!- selroc has joined #linuxcnc-devel
[06:03:33] -!- selroc has quit [Client Quit]
[06:54:41] -!- Jin^eLD has joined #linuxcnc-devel
[07:38:19] -!- JT-Shop has quit [Read error: Connection reset by peer]
[07:41:47] -!- jthornton has quit [Read error: Connection reset by peer]
[07:42:11] -!- jthornton has joined #linuxcnc-devel
[07:42:35] -!- JT-Shop has joined #linuxcnc-devel
[08:09:44] -!- jthornton has quit [Read error: Connection reset by peer]
[08:10:22] -!- JT-Shop has quit [Read error: Connection reset by peer]
[08:10:40] -!- jthornton has joined #linuxcnc-devel
[08:10:50] -!- JT-Shop has joined #linuxcnc-devel
[09:41:41] -!- Roguish has quit [Remote host closed the connection]
[10:36:05] -!- jthornton has quit [Read error: Connection reset by peer]
[10:37:03] -!- JT-Shop has quit [Read error: Connection reset by peer]
[10:37:22] -!- jthornton has joined #linuxcnc-devel
[10:37:30] -!- JT-Shop has joined #linuxcnc-devel
[10:48:39] -!- Roguish has joined #linuxcnc-devel
[11:06:21] -!- njh has quit [Ping timeout: 252 seconds]
[11:13:49] -!- rob_h has quit [Ping timeout: 250 seconds]
[12:56:37] -!- rob_h has joined #linuxcnc-devel
[13:05:52] -!- Robh__ has joined #linuxcnc-devel
[13:08:39] -!- rob_h has quit [Ping timeout: 250 seconds]
[13:49:15] -linuxcnc-github:#linuxcnc-devel- [13linuxcnc] 15KurtJacobson opened pull request #507: docs: add missing status items to python interface docs (06master...06py_interface_docs2) 02 https://github.com/LinuxCNC/linuxcnc/pull/507
[13:58:33] -linuxcnc-github:#linuxcnc-devel- [13linuxcnc] 15KurtJacobson opened pull request #508: fix #505: add optional spindle num argument to py interface `command.brake` method (06master...06multispindle_brake) 02 https://github.com/LinuxCNC/linuxcnc/pull/508
[14:13:22] -!- njh has joined #linuxcnc-devel
[14:52:12] <hazzy-m> I am a big fan of the branch-commit-pr-merge workflow
[14:52:46] <hazzy-m> Having changes enter master thru a PR makes it easy to document what changes were made, by whom, and why, and provides a convenient way to discuss changes before (and after) they have been merged.
[14:53:41] <hazzy-m> But when it takes weeks for even the simplest of PRs to be merged it becomes difficult to move forward
[14:53:42] -!- rmu has quit [Ping timeout: 252 seconds]
[14:53:49] <hazzy-m> I have to keep track of what has and has not been merged so things don't get fixed twice
[14:54:06] <hazzy-m> and if something is fixed twice by accident (which I did this morning), then it will probably end up making the life of whoever ends up merging it harder due to conflicts
[14:54:22] <hazzy-m> I know you all are busy, and several of you aren't spending nearly as much time on LinuxCNC these days, which I completely understand, so don't think I am complaining, I am not!
[14:54:43] <hazzy-m> it's just that there is less man power here than there used to be to take care of things like PRs.
[14:55:19] -!- rmu has joined #linuxcnc-devel
[14:55:44] <hazzy-m> So I guess what I am getting at is, while I would rather not have the responsibility of push access to the main repo, if it would reduce the load on you all for all these trivial doc fix PRs I keep making then maybe that is something we could consider.
[15:16:19] -!- ve7it has joined #linuxcnc-devel
[15:19:24] -!- njh has quit [Ping timeout: 252 seconds]
[15:36:50] -!- njh has joined #linuxcnc-devel
[16:09:38] -linuxcnc-github:#linuxcnc-devel- [13linuxcnc] 15c-morley pushed 1 new commit to 06qt5vcp_py2: 02 https://github.com/LinuxCNC/linuxcnc/commit/b95d23913638c0c8b9792c708cdf1388c21466db
[16:09:38] -linuxcnc-github:#linuxcnc-devel- 13linuxcnc/06qt5vcp_py2 14b95d239 15Chris Morley: qtvcp -momentary action buttons can be state labeled...
[16:16:18] -!- andypugh has joined #linuxcnc-devel
[16:16:43] <jthornton> hazzy-m: if you see doc fixes that I miss and I miss a lot let me know and I'll take care of them
[16:17:54] <andypugh> I am baffled.. (again)
[16:18:33] <andypugh> As far as I can see the spindle speed for each spindle should be stored in emcstatus.
[16:19:03] <hazzy-m> jthornton: Thank you! But sometimes it is easyer to fix them than explain what needs to be fixed!
[16:20:07] <andypugh> This line here: https://github.com
[16:21:44] <andypugh> But if I add some printf : for (int i = 0; i < 3; i++) {printf("spindle %i speed %f\n", i, emcStatus->motion.spindle[i].speed) ;}
[16:22:31] <andypugh> It seems that all the spindle speeds get set to zero between calls, but I haven’t managed to find anywhere else in the code that puts values in that array..
[16:25:30] <andypugh> Ah, a clue, only in MDI…
[16:25:51] <andypugh> G-code behaves as-expected
[16:31:37] <JT-Shop> hazzy-m: I get in trouble with my wife all the time not saying what I'm thinking ie taking short cuts lol... if you have a PR for docs and I miss it let me know
[16:32:05] * JT-Shop heads to the fab shop to make some sparks
[16:34:32] -!- emc has joined #linuxcnc-devel
[16:35:59] -!- emc has quit [Client Quit]
[16:36:18] -!- JT-Fshop has joined #linuxcnc-devel
[16:50:04] -linuxcnc-github:#linuxcnc-devel- [13linuxcnc] 15andypugh closed pull request #507: docs: add missing status items to python interface docs (06master...06py_interface_docs2) 02 https://github.com/LinuxCNC/linuxcnc/pull/507
[16:50:50] -linuxcnc-github:#linuxcnc-devel- [13linuxcnc] 15andypugh pushed 2 new commits to 06master: 02 https://github.com/LinuxCNC/linuxcnc/compare/aca39d5b716c...d6b7997774f9
[16:50:50] -linuxcnc-github:#linuxcnc-devel- 13linuxcnc/06master 149933ccd 15Kurt Jacobson: fix #505: add optional spindle num argument to `cmd.brake`...
[16:50:50] -linuxcnc-github:#linuxcnc-devel- 13linuxcnc/06master 14d6b7997 15andypugh: Merge pull request #508 from KurtJacobson/multispindle_brake...
[17:00:05] <hazzy-m> andypugh: Thank you! Now my multispindle test UI should run again
[17:02:57] <andypugh> hazzy-m: Do you have the time to look at this spindle speed thing? Maybe a fresh set of eyes can help?
[17:04:51] <hazzy-m> andypugh: sure, I'll try!
[17:04:55] <andypugh> There used to be a static global variable in emccanon that held the current spindle speed. I moved that to inside the emcStatus structure (of type EMC_STAT defined in emc_nml.hh)
[17:05:45] <hazzy-m> just testing your changes to the spindle overrides, still not right, but much more predictable, which is a step in the right direction!
[17:06:09] <andypugh> But it looks like that is reset to zero every time emccanon exits (though I am about to look to see if anything in the joint stuff is retained)
[17:08:30] <hazzy-m> ok, i'm going to try and understand how emccanon SET_SPINDLE_SPEED works
[17:29:16] <andypugh> You don’t particularly need to. The real question is why the emcStatus->motion.spindle[i].speed gets set to zero all the time
[17:29:53] <andypugh> Before: spindle 0 speed 0.000000
[17:29:54] <andypugh> Before: spindle 1 speed 0.000000
[17:29:55] <andypugh> Before: spindle 2 speed 0.000000
[17:29:56] <andypugh> After: spindle 0 speed 100.000000
[17:29:57] <andypugh> After: spindle 1 speed 0.000000
[17:29:58] <andypugh> After: spindle 2 speed 0.000000
[17:30:06] <andypugh> Happens every time with S100.
[17:30:36] <andypugh> I assume that something in the declarations of EMC_STAT type isn’t right, and the structure isn’t static.
[17:32:14] <hazzy-m> I don't know C/C++, so I'm trying to get the gist of how it all works
[17:32:38] <hazzy-m> is it possible to print the object ID like it is in python and see if it changes?
[17:33:15] <hazzy-m> then at least you'd know if it was static or not
[17:34:24] <andypugh> The address doesn’t change....
[17:35:03] <andypugh> printf("Address of spindle speed = %p\n", &emcStatus->motion.spindle);
[17:35:05] <hazzy-m> but I guess it could be a new instance at the same adress ...
[17:35:12] <andypugh> Gives the same answer every time
[17:35:29] <andypugh> Yes, possibly. I know very little about C++ too
[17:35:43] <andypugh> I normally only work in C.
[17:56:01] <hazzy-m> andypugh: amiright that there there are no other emcStatus values set in emcconnon?
[17:56:56] <andypugh> There is one other thing set.
[17:57:55] <andypugh> emcStatus->task.programUnits = in_unit;
[17:58:39] <andypugh> Before I changed things about everything was stored as globals in emccanon, I will go back to that, perhaps there is a reason that I don’t know.
[18:07:18] <hazzy-m> I'm wondering if it is something simple in the syntax. In `emcStatus->task.programUnits = in_unit` programUnits is a int (I assume) whereas in `emcStatus->motion.spindle[s].speed` spindle is an array, so wonder if you might need to dereferance it or something
[18:21:29] <hazzy-m> andypugh: I got a negative speed to show up in emcStatus before setting the speed
[18:21:50] * hazzy-m sent a long message: < https://matrix.org >
[18:22:17] <hazzy-m> which would indicate it is not being reset to 0 ...
[18:23:00] <andypugh> It works if you put the m3 on the same line, and that seems to indicate that if you stay “in” emcannon it is OK.
[18:23:44] <hazzy-m> yes, but I got a neg with out using any m codes, so something is persistant
[18:23:44] <andypugh> (It also works in G-code, so it looks like emcStatus goes out of scope when you complete an MDI command)
[18:24:06] <hazzy-m> could be
[18:24:18] <hazzy-m> investigation to be continued after a supper break ..
[18:37:09] -linuxcnc-github:#linuxcnc-devel- [13linuxcnc] 15jethornton pushed 1 new commit to 062.7: 02 https://github.com/LinuxCNC/linuxcnc/commit/85b3fd171f4a698a11c53b04c69b8c35aa62ef2d
[18:37:09] -linuxcnc-github:#linuxcnc-devel- 13linuxcnc/062.7 1485b3fd1 15jethornton: Docs: add missing info for compensation file and expand on description....
[19:15:04] -!- pcw_mesa has joined #linuxcnc-devel
[19:22:25] -linuxcnc-github:#linuxcnc-devel- [13linuxcnc] 15jethornton pushed 1 new commit to 06master: 02 https://github.com/LinuxCNC/linuxcnc/commit/3174e77c43cf3e1e8480509c8f66dba0afeaeaf9
[19:22:25] -linuxcnc-github:#linuxcnc-devel- 13linuxcnc/06master 143174e77 15jethornton: Docs: add missing info for compensation file and expand on description....
[19:32:48] Jin^eLD is now known as Jin|away
[20:05:44] -!- Robh__ has quit [Ping timeout: 276 seconds]
[20:32:39] <hazzy-m> andypugh: the emcStatus values are updated somewhere, but I can't find were. Do you know where that occurs?
[20:33:03] <andypugh> I think I have a fix ready to push
[20:33:25] <hazzy-m> excellent!!
[20:33:38] <andypugh> My suspicion is the call to GET_EXTERNAL_SPEED
[20:34:12] <andypugh> But I went with putting everything back in emccanon module-global variables.
[20:34:45] -linuxcnc-github:#linuxcnc-devel- [13linuxcnc] 15andypugh pushed 2 new commits to 06master: 02 https://github.com/LinuxCNC/linuxcnc/compare/3174e77c43cf...7fb914d198f6
[20:34:45] -linuxcnc-github:#linuxcnc-devel- 13linuxcnc/06master 145b477ad 15andy pugh: Multispindle: Make interp_check do the right things now that we use $ not E / D...
[20:34:45] -linuxcnc-github:#linuxcnc-devel- 13linuxcnc/06master 147fb914d 15andy pugh: Multispindle: Make S commands modal again....
[20:41:52] <hazzy-m> better
[20:42:24] -linuxcnc-github:#linuxcnc-devel- [13linuxcnc] 15andypugh pushed 1 new commit to 06master: 02 https://github.com/LinuxCNC/linuxcnc/commit/d42d9b0970001be2d5ad01760f0f7269ebd3ab90
[20:42:24] -linuxcnc-github:#linuxcnc-devel- 13linuxcnc/06master 14d42d9b0 15andy pugh: Multispindle: Remove debug message left in in error....
[20:42:43] <hazzy-m> M3 and M4 change the direction of BOTH spindle ..
[20:43:50] <hazzy-m> if issued without an $ word
[20:45:57] <andypugh> Yes, that’s deliberate
[20:46:42] <hazzy-m> seems like it should give an error, no?
[20:46:42] <andypugh> M3 M4 M5 operate on all spindles simultaneously unless told otherwise
[20:47:04] <andypugh> This was part of the plan to make simultaneous starts easy.
[20:47:45] <andypugh> Before I realised that the signals won’t go to the hardware until the write function, so they would start simultaneously anyway
[20:49:36] <andypugh> Anyway, nearly 2am here, time to sleep.
[20:49:43] -!- andypugh has quit [Quit: andypugh]
[20:50:06] <hazzy-m> hmm, but it seems a little dangerous to have both start, it would be awful easy to start both from MDI by accident and cause an accident. I think for it should requite the $ word for a multispindle machine
[20:50:23] <hazzy-m> night
[21:01:33] <skunkworks> pcw_mesa: that worked!
[21:01:41] <Tom_L> yay
[21:02:47] <skunkworks> https://www.youtube.com
[21:03:14] <skunkworks> it needs a simple amplifier on the pin.. I just cobbled it together for testing
[21:04:02] <skunkworks> the encoder scale ended up being .065 I have not figured out what that means yet
[21:04:37] <skunkworks> it must actually use one or all of the hal sensors - because it fires when I turn the spindle by hand
[21:04:46] <skunkworks> pcw_home:
[21:07:01] <skunkworks> there are pid settings in the drive - but I have yet to find a manual for it that I can read
[21:07:15] <skunkworks> (it hunts around the setpoint for a bit)
[21:07:32] -!- Roguish has quit [Quit: ChatZilla 0.9.92-rdmsoft [XULRunner 35.0.1/20150122214805]]
[21:49:52] -!- c-log has quit [Ping timeout: 272 seconds]
[21:51:10] -!- c-log has joined #linuxcnc-devel