#linuxcnc | Logs for 2018-12-08
Back
[00:46:37] -!- ferdna has joined #linuxcnc
[00:53:52] -!- renesis has quit [Remote host closed the connection]
[00:53:59] -!- renesis has joined #linuxcnc
[01:02:38] -!- ve7it has quit [Remote host closed the connection]
[01:05:39] -!- ferdna has quit [Quit: Leaving]
[01:26:25] -!- CaptHindsight has quit [Quit: Leaving]
[01:30:03] -!- CP_Away has joined #linuxcnc
[01:33:25] -!- gregcnc has quit [Ping timeout: 268 seconds]
[01:33:25] -!- Contract_Pilot has quit [Ping timeout: 268 seconds]
[01:33:45] -!- gregcnc has joined #linuxcnc
[01:36:40] -!- ziper has quit [Read error: Connection reset by peer]
[01:48:00] -!- c-log has quit [Ping timeout: 250 seconds]
[01:49:28] -!- c-log has joined #linuxcnc
[03:06:09] -!- Deejay has joined #linuxcnc
[03:06:58] <Deejay> moin
[03:10:20] -!- c-log has quit [Ping timeout: 272 seconds]
[03:11:46] -!- c-log has joined #linuxcnc
[03:11:46] -!- c-log has quit [Changing host]
[03:11:46] -!- c-log has joined #linuxcnc
[03:22:22] -!- connor_goodwolf has quit [Ping timeout: 272 seconds]
[04:07:22] -!- leorat has quit [Quit: leorat]
[04:18:08] -!- JesusAlos has quit [Quit: JesusAlos]
[04:30:01] -!- ty2u has quit [Quit: It is our time to be alive]
[04:30:29] -!- ty2u has joined #linuxcnc
[04:42:03] -!- asdfasd1 has joined #linuxcnc
[05:25:32] -!- weenerdog has quit [Ping timeout: 250 seconds]
[05:45:56] <jthornton> morning
[05:46:12] <Deejay> hey
[05:47:21] <XXCoder> hey jthornton
[06:04:56] <jthornton> what's up today?
[06:05:23] <XXCoder> not much just played with wii u some and pondered a bit on disapperance of my doc change
[06:05:37] <XXCoder> i pushed 3 very minor changes and i cant find it anywhere
[06:06:41] <jthornton> I don't see any log of a push on the devel channel
[06:07:23] <XXCoder> i just directly edited file on git (it was very simple) and added umm request i think pull request? forgot
[06:07:50] <jthornton> ah someone has to react to a pull request
[06:08:31] <XXCoder> i see pull list and none of em is by me
[06:08:49] <XXCoder> nov 26th something I think
[06:11:57] <MarcelineVQ> what's your git name
[06:12:03] <XXCoder> rredford
[06:13:57] <MarcelineVQ> what was the branch you were working on called?
[06:14:25] <XXCoder> thats the sad thing, i cant remember but is there a way to show my activity history in any git?
[06:16:29] <MarcelineVQ> dunno, but you're not in any closed or open pr's https://github.com✓&q=rredford
[06:16:52] <XXCoder> bah no iea what happened then
[06:17:14] <XXCoder> what I did is just edit 2 files then made file change request somehow
[06:17:21] <XXCoder> probably failed to finalize it or something
[06:18:53] <MarcelineVQ> on github you make your changes on a branch, push to that branch on your own repo, then make a pull request to linuxcnc for them to pull your branch from your repo
[06:20:49] <MarcelineVQ> if you could remember what you called your branch that you were making changes on you could at least confirm if you pushed it to your own repo
[06:21:20] <XXCoder> it dont really matter can always do it agaim its literally just 4 words total change
[06:22:02] <jthornton> I need to get this new PC setup to push this morning
[06:22:04] <XXCoder> add rolfmill to vismach sim machines list, change rolfmill.hal for comments to "most comments is in rolfmill, and some in rolfmill.hal"
[06:22:17] <XXCoder> not exact words I used but you get the idea
[06:22:55] <jthornton> rolfmill is in the sim axis vismach
[06:23:08] <XXCoder> yeah but doc is missing it
[06:23:32] <jthornton> where are the sim's listed in the documents?
[06:23:43] <XXCoder> lemme re-find it again
[06:24:35] <XXCoder> https://github.com
[06:24:42] <XXCoder> one of 3 I think lemme find others
[06:25:12] <XXCoder> no not that one
[06:25:15] <XXCoder> https://github.com
[06:25:25] <XXCoder> i just added -- rolfmill at end
[06:26:09] <XXCoder> and in https://github.com change "Comments in rolfmill.hal explain step by step the process to build." to "Comments is in rolfmill, and some in rolfmill.hal explain step by step the process to build.
[06:26:35] <MarcelineVQ> what does is in rolfmill mean?
[06:26:48] <XXCoder> MarcelineVQ: rolfmill is vismach file
[06:26:56] <XXCoder> its the file that has HUGE amount of comments
[06:27:05] <XXCoder> https://github.com enjoy
[06:27:05] <jthornton> yea it's really a bad description and should be more descriptive of what it is
[06:27:08] <MarcelineVQ> best to mention that then so people don't have to ask :>
[06:27:45] <XXCoder> hmm yeah "in rolfmach vismach file, and some in rolfmill.hal"
[06:27:49] <XXCoder> more clear?
[06:28:20] <XXCoder> let me try edit the readme again see step by step if I did it correctly
[06:28:21] <MarcelineVQ> yes
[06:28:33] <XXCoder> ah!
[06:28:39] <XXCoder> "edit the file in your fork"
[06:28:49] <XXCoder> guess it clones it to my git when i do
[06:28:56] <XXCoder> lemme see same file in my copy
[06:29:07] <jthornton> I still don't see where your saying it is in the documents
[06:29:41] <XXCoder> nope file is same there also. weird
[06:29:51] <jthornton> ah I see what your talking about the vismach readme doesn't mention it
[06:30:01] <XXCoder> jt let me try something tho
[06:30:08] <XXCoder> im now editing my copy
[06:30:13] <XXCoder> then see if can pull
[06:30:43] <jthornton> you really should name it 3-axis-mill or similar
[06:31:45] <XXCoder> i suppose. yeah. though I think if someone tries to use it, it'll be either broken or create rolf folder in usr
[06:31:58] <XXCoder> because one of config points to my folder
[06:32:16] <jthornton> yea I'll fix that
[06:32:28] <XXCoder> do I add my name in comment or what? saw some configs have that
[06:32:45] <XXCoder> i just left it rolfmill because i named it when I was building it
[06:33:23] <XXCoder> maybe tutoral-vismach ?
[06:33:24] <jthornton> I understand that
[06:34:51] <XXCoder> is that name workable?
[06:36:46] <jthornton> I think that should be in the readme and I need to expand that a bit the name should describe the configuration
[06:37:08] <XXCoder> it'd make name bit long maybe just 3axis-tutoral
[06:37:14] <jthornton> gotta do some hard drive swapping to get back to where I was working before adding the new pc
[06:40:00] <XXCoder> damn
[06:40:08] <XXCoder> cant recall how to do git pull into my pc
[06:40:22] <XXCoder> so I can make few changes before update then do pull request
[06:40:32] <XXCoder> been too long
[06:40:40] -!- c-log has quit [Ping timeout: 244 seconds]
[06:42:08] <jthornton> git clone https://github.com some_directory
[06:42:55] <jthornton> damn I was late and missed the lights coming on good thing nobody laid an egg from the roost
[06:42:57] -!- c-log has joined #linuxcnc
[06:42:57] -!- c-log has quit [Changing host]
[06:42:57] -!- c-log has joined #linuxcnc
[06:43:11] <XXCoder> whew heh also thanks
[06:43:39] <MarcelineVQ> you typically want to clone your own github fork so you can update it independantly, and it makes PR's straightforward
[06:43:49] <XXCoder> marc yeah thats what I am doing now
[06:44:04] <XXCoder> cloned my repo not master
[06:44:36] <XXCoder> what you think of 3axis-tutoral name?
[06:44:57] <MarcelineVQ> for?
[06:45:03] <XXCoder> name of vismach
[06:45:14] <XXCoder> specifically one currently named rolfmill
[06:45:28] <MarcelineVQ> If that's what it is then it's a good name, don't know anything about it
[06:45:37] <XXCoder> ok
[06:46:48] <jthornton> I think that would make more sense if there was a chapter in the documents called vismach tutorial
[06:47:26] <jthornton> and that is not a bad idea...
[06:47:35] <XXCoder> yeah
[06:47:36] <Tom_L> it might attract more attention if it was named what it did for sure
[06:47:48] <MarcelineVQ> there is a bit of one here http://linuxcnc.org
[06:47:59] <XXCoder> i noticed something though, vismach fules is not in same directory as HAL files
[06:48:51] <XXCoder> think its in /usr/bin folder but i dont know where thats located in source
[06:49:16] <XXCoder> ah i think i found it
[06:49:41] <XXCoder> nope
[06:50:29] <jthornton> yea the sims became a pia when they hid all the files and made everything a simlink you can't even copy... rambling off
[06:50:53] <XXCoder> eh as well as leave it there so people can copy
[06:51:03] <XXCoder> anyway
[06:51:06] <XXCoder> now working on naming
[06:51:17] <jthornton> rambling back on and being forced to make a copy of a sim just to look at it is dumb
[06:53:00] <XXCoder> -- 3axis-tutoral: vismach that have comments in 3axis-tutoral as well as 3axis-tutoral.hal in order to show you how to build your own machine and use it.
[06:53:03] <XXCoder> what you think
[06:53:52] <jthornton> I think the sim name should be 3axis-mill and the tutorial part should be in the readme as well as a chapter vismach tutorial
[06:54:17] * Tom_L waits for the dust to settle
[06:56:01] <jthornton> did you get any snow? we are supposed to get some this afternoon
[06:56:29] <Tom_L> they put brine on all the roads.... false alarm
[06:57:17] <Tom_L> it all stayed in Ok it appears
[06:57:41] <Tom_L> looks like you're right on the edge of it
[06:58:06] <XXCoder> okay! renaming is done
[06:58:10] <XXCoder> lets see if it even runs
[06:59:35] <XXCoder> its 2.8 version lol
[07:01:26] <XXCoder> jthornton: can you pull and test before confirming it?
[07:01:40] <XXCoder> if not ill find a way to get 2.8 to test with
[07:02:10] <jthornton> I don't know anything about PR's
[07:02:45] <XXCoder> 2.7 and 2.8 is bit different so not sure how to change both versions
[07:03:30] <jthornton> yea the configs are different for each one
[07:04:01] <XXCoder> i renamed folder, files and edited files to point to correct files
[07:04:11] <XXCoder> added creator comment to vismach file
[07:04:40] <XXCoder> i dont want to do a untested pull
[07:05:30] <jthornton> unless you have push rights you can't push your changes so what ever you do is safe
[07:05:52] <XXCoder> yeah as well as push it to my version
[07:06:08] <XXCoder> so git comment? how do I update files list?
[07:06:46] <jthornton> did you mean git commit? or comment?
[07:06:53] <XXCoder> commit sorry
[07:07:15] <MarcelineVQ> by update files list do you mean add changed files to a commit?
[07:07:17] <jthornton> commit just saves the changes to your local copy
[07:07:29] <XXCoder> ok git status shows one file changed and 5 files deleted
[07:07:38] <XXCoder> not surpised. need to add new name folder and files
[07:07:54] <XXCoder> it also tells me how to. nice
[07:08:23] <XXCoder> okay now it has new files
[07:08:43] -!- bedah has quit [Quit: Ex-Chat]
[07:09:04] -!- bedah has joined #linuxcnc
[07:10:00] <XXCoder> ok now its "renamed" nice
[07:10:03] <XXCoder> been so long lol
[07:12:20] <XXCoder> dammit mispelled tutorial so i have to do it all over
[07:12:58] <MarcelineVQ> just make another commit with your changes
[07:13:06] <XXCoder> nah havent commented
[07:13:11] <XXCoder> *commited
[07:13:44] <MarcelineVQ> I also use git rebase -i to combine multiple changes before pushing, but never rebase someone else's commits, only your own if you have a few in a row
[07:15:20] <MarcelineVQ> you can try git rebase -i HEAD~4 to see an example of what I mean by that. just exit without changing anything
[07:18:09] <XXCoder> okay re-rename is done lol
[07:19:05] <XXCoder> okay git commit how do I push it to git repo?
[07:19:52] <MarcelineVQ> it depends what your remotes are, what does git remote -v say
[07:20:18] <XXCoder> it lists my git version of linuxcnc repo
[07:20:22] <XXCoder> fetch then push
[07:21:06] <MarcelineVQ> if it only has yours or it says origin is yours git push is fine
[07:22:32] <XXCoder> warning: push.default is unset; its implicit value ha....
[07:23:16] <XXCoder> oh nm
[07:23:17] <MarcelineVQ> if it doesn't work try git push origin assuming origin is what remove says your own repo was called
[07:23:18] <XXCoder> a second
[07:23:34] <MarcelineVQ> When successful the new branch should show up at the top of your forked linuxcnc repo, there might even be a link to make a PR from it at the same time, I can't recall
[07:23:56] <MarcelineVQ> *what remote says your own repo is called
[07:24:45] <XXCoder> ya just needed to login
[07:25:41] <XXCoder> https://github.com
[07:26:45] <MarcelineVQ> what's this? https://github.com
[07:26:57] <XXCoder> line 45?
[07:27:01] <MarcelineVQ> yes
[07:27:12] <XXCoder> its efault directory when you want open nc files
[07:27:20] <XXCoder> it should be example nc files
[07:29:09] <XXCoder> folder
[07:29:20] <MarcelineVQ> ah hmm, is it made clear somewhere else that this will need to change? no one else will have /home/rolf hehe
[07:29:28] <XXCoder> indeed
[07:29:46] <XXCoder> no, jt is planning to change it once im done so i added comment to remind
[07:30:05] <XXCoder> i need to copy 2.7 version and change that one aksio
[07:31:18] <MarcelineVQ> heyyy wait a minute, this says master :( you didn't make a branch for these changes?
[07:31:28] -!- Inline has quit [Remote host closed the connection]
[07:32:11] <XXCoder> i havent changed linuxcnc git just my copy though not sure what to do atm
[07:32:15] <MarcelineVQ> You should always make a new branch when making changes you intend to do a PR with.
[07:32:27] <XXCoder> can I rename it to not master?
[07:32:48] <MarcelineVQ> No but you should be able to move this to a branch, lemme see..
[07:32:59] <XXCoder> yeah I see swiychj branches/tags
[07:33:06] <XXCoder> "find or create a branch"
[07:33:11] <XXCoder> switch
[07:33:43] <XXCoder> so what name would make sense?
[07:33:51] <XXCoder> i see stuff like andy-whatever
[07:34:11] <MarcelineVQ> basically you want to be on master and then git checkout -c mynewbranchname before you even start making changes, it's good practice, don't do that just now though
[07:34:25] <jthornton> yea usually the branch is your name-what-it-is
[07:34:32] <MarcelineVQ> You'll need to google how to move your commit to another branch, I'm not sure how to do that
[07:34:49] <XXCoder> rredford-3daxis-tutorial it is then
[07:35:08] <MarcelineVQ> it jthornton's going to make changes anyway you might just want to leave it, let him clone your repo, make the changes and do the PR
[07:35:40] <jthornton> MarcelineVQ: I have push rights but have never done a pr
[07:35:49] <MarcelineVQ> Like, no sense doing a PR, and then doing a PR to do one change
[07:35:59] <MarcelineVQ> Neither has XXCoder it sounds like hehe
[07:36:13] <XXCoder> i have had, but been years
[07:36:15] <MarcelineVQ> Not that I'm some expert, don't want to imply that
[07:41:08] <XXCoder> jthornton: should I just do pr?
[07:49:05] <jthornton> that's up to you, I don't know anything about pr's except what they are
[07:52:20] * jthornton can't figure out where the mice are getting in the basement...
[07:52:33] <jthornton> shutting down for a bit...
[07:52:37] <XXCoder> doctor mouse who ;)
[07:53:01] <jthornton> just put out some sticky traps and mouse traps again...
[07:53:08] -!- jthornton has quit [Remote host closed the connection]
[08:00:02] -!- Inline has joined #linuxcnc
[08:03:42] -!- nick001 has quit [Ping timeout: 250 seconds]
[08:05:18] -!- jthornton has joined #linuxcnc
[08:05:48] <XXCoder> wb
[22:12:50] -!- logs has joined #linuxcnc
[22:39:25] -!- Tom_itx has joined #linuxcnc
[22:58:28] -!- Tom_itx has quit [Quit: Leaving]
[23:40:15] -!- MarcelineVQ has quit [Read error: Connection reset by peer]
[23:40:57] -!- MarcelineVQ has joined #linuxcnc